[LTP] [PATCH 8/8] syscalls/setresuid03: Convert to new API

Petr Vorel pvorel@suse.cz
Mon Sep 13 16:46:33 CEST 2021


> On 09. 09. 21 18:32, pvorel wrote:
> >> -    if (getpwnam("bin") == NULL) {
> >> -        tst_brkm(TBROK, NULL, "bin must be a valid user.");
> >> +    if (TST_ERR != tc->exp_errno) {
> > nit: checkpatch complains (TST_ERR should be second)

> checkpatch.pl wrongly assumes that TST_ERR is a constant.
Yep, variable named upper case is confusing for perl script.
Sorry for not detecting it myself. I suppose we should whitelist
TST_{ERR,PASS,RET} from these checks in our vendored checkpatch.pl.

Kind regards,
Petr


More information about the ltp mailing list