[LTP] [PATCH 2/2] pkey: correct the PKEY_DISABLE_ACCESS definitions on PowerPC

[Li Wang]

On Mon, Apr 11, 2022 at 6:57 PM Jan Stancek <jstancek@redhat.com> wrote:

> On Mon, Apr 11, 2022 at 11:41 AM Li Wang <liwang@redhat.com> wrote:
> >
> > Reference:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e9506394a159
> >
> > Signed-off-by: Li Wang <liwang@redhat.com>
> > ---
> >  testcases/kernel/syscalls/pkeys/pkey.h | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/testcases/kernel/syscalls/pkeys/pkey.h
> b/testcases/kernel/syscalls/pkeys/pkey.h
> > index 6e32326b6..6cda88ff1 100644
> > --- a/testcases/kernel/syscalls/pkeys/pkey.h
> > +++ b/testcases/kernel/syscalls/pkeys/pkey.h
> > @@ -11,6 +11,13 @@
> >  #include "lapi/syscalls.h"
> >  #include "lapi/mmap.h"
> >
> > +#if defined(__powerpc__) || defined(__ppc__)
> > +# undef PKEY_DISABLE_ACCESS
> > +# define PKEY_DISABLE_ACCESS 0x3
>
> Where does powerpc define PKEY_DISABLE_ACCESS as 0x3?
>

Good question, I previously thought that was officially defined as 0x3 on
PowerPC (per Ram's patch).

But after looking at 'powerpc/include/uapi/asm/mman.h' it still includes
header which define PKEY_DISABLE_ACCESS as 0x1.
    #include <asm-generic/mman-common.h>

@Ram Pai, could you explain why you're using 0x3 in kselftest?
Did I miss anything?


-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220411/7bda5987/attachment.htm>