[LTP] [PATCH v2 2/3] confstr01: Update to X/Open 7 (POSIX 2008)

[Cyril Hrubis]

Hi!
>  static struct test_case_t {
>  	int value;
>  	char *name;
> @@ -30,55 +27,27 @@ static struct test_case_t {
>  	{ _CS_PATH, "PATH" },
>  	{ _CS_GNU_LIBC_VERSION, "GNU_LIBC_VERSION" },
>  	{ _CS_GNU_LIBPTHREAD_VERSION, "GNU_LIBPTHREAD_VERSION" },
> -
> -/* checking for obsolete configurations */
> -#ifdef _CS_XBS5_ILP32_OFF32_CFLAGS
> -	{ _CS_XBS5_ILP32_OFF32_CFLAGS, "XBS5_ILP32_OFF32_CFLAGS" },
> -#endif
> -#ifdef _CS_XBS5_ILP32_OFF32_LDFLAGS
> -	{ _CS_XBS5_ILP32_OFF32_LDFLAGS, "XBS5_ILP32_OFF32_LDFLAGS" },
> -#endif
> -#ifdef _CS_XBS5_ILP32_OFF32_LIBS
> -	{ _CS_XBS5_ILP32_OFF32_LIBS, "XBS5_ILP32_OFF32_LIBS" },
> -#endif
> -#ifdef _CS_XBS5_ILP32_OFF32_LINTFLAGS
> -	{ _CS_XBS5_ILP32_OFF32_LINTFLAGS, "XBS5_ILP32_OFF32_LINTFLAGS" },
> -#endif
> -#ifdef _CS_XBS5_ILP32_OFFBIG_CFLAGS
> -	{ _CS_XBS5_ILP32_OFFBIG_CFLAGS, "XBS5_ILP32_OFFBIG_CFLAGS" },
> -#endif
> -#ifdef _CS_XBS5_ILP32_OFFBIG_LDFLAGS
> -	{ _CS_XBS5_ILP32_OFFBIG_LDFLAGS, "XBS5_ILP32_OFFBIG_LDFLAGS" },
> -#endif
> -#ifdef _CS_XBS5_ILP32_OFFBIG_LIBS
> -	{ _CS_XBS5_ILP32_OFFBIG_LIBS, "XBS5_ILP32_OFFBIG_LIBS" },
> -#endif
> -#ifdef _CS_XBS5_ILP32_OFFBIG_LINTFLAGS
> -	{ _CS_XBS5_ILP32_OFFBIG_LINTFLAGS, "XBS5_ILP32_OFFBIG_LINTFLAGS" },
> -#endif
> -#ifdef _CS_XBS5_LP64_OFF64_CFLAGS
> -	{ _CS_XBS5_LP64_OFF64_CFLAGS, "XBS5_LP64_OFF64_CFLAGS" },
> -#endif
> -#ifdef _CS_XBS5_LP64_OFF64_LDFLAGS
> -	{ _CS_XBS5_LP64_OFF64_LDFLAGS, "XBS5_LP64_OFF64_LDFLAGS" },
> -#endif
> -#ifdef _CS_XBS5_LP64_OFF64_LIBS
> -	{ _CS_XBS5_LP64_OFF64_LIBS, "XBS5_LP64_OFF64_LIBS" },
> -#endif
> -#ifdef _CS_XBS5_LP64_OFF64_LINTFLAGS
> -	{ _CS_XBS5_LP64_OFF64_LINTFLAGS, "XBS5_LP64_OFF64_LINTFLAGS" },
> -#endif
> -#ifdef _CS_XBS5_LPBIG_OFFBIG_CFLAGS
> -	{ _CS_XBS5_LPBIG_OFFBIG_CFLAGS, "XBS5_LPBIG_OFFBIG_CFLAGS" },
> -#endif
> -#ifdef _CS_XBS5_LPBIG_OFFBIG_LDFLAGS
> -	{ _CS_XBS5_LPBIG_OFFBIG_LDFLAGS, "XBS5_LPBIG_OFFBIG_LDFLAGS" },
> -#endif
> -#ifdef _CS_XBS5_LPBIG_OFFBIG_LIBS
> -	{ _CS_XBS5_LPBIG_OFFBIG_LIBS, "XBS5_LPBIG_OFFBIG_LIBS" },
> -#endif
> -#ifdef _CS_XBS5_LPBIG_OFFBIG_LINTFLAGS
> -	{ _CS_XBS5_LPBIG_OFFBIG_LINTFLAGS, "XBS5_LPBIG_OFFBIG_LINTFLAGS" },
> +	{ _CS_POSIX_V7_ILP32_OFF32_CFLAGS, "POSIX_V7_ILP32_OFF32_CFLAGS" },
> +	{ _CS_POSIX_V7_ILP32_OFF32_LDFLAGS, "POSIX_V7_ILP32_OFF32_LDFLAGS" },
> +	{ _CS_POSIX_V7_ILP32_OFF32_LIBS, "POSIX_V7_ILP32_OFF32_LIBS" },
> +	{ _CS_POSIX_V7_ILP32_OFFBIG_CFLAGS, "POSIX_V7_ILP32_OFFBIG_CFLAGS" },
> +	{ _CS_POSIX_V7_ILP32_OFFBIG_LDFLAGS, "POSIX_V7_ILP32_OFFBIG_LDFLAGS" },
> +	{ _CS_POSIX_V7_ILP32_OFFBIG_LIBS, "POSIX_V7_ILP32_OFFBIG_LIBS" },
> +	{ _CS_POSIX_V7_LP64_OFF64_CFLAGS, "POSIX_V7_LP64_OFF64_CFLAGS" },
> +	{ _CS_POSIX_V7_LP64_OFF64_LDFLAGS, "POSIX_V7_LP64_OFF64_LDFLAGS" },
> +	{ _CS_POSIX_V7_LP64_OFF64_LIBS, "POSIX_V7_LP64_OFF64_LIBS" },
> +	{ _CS_POSIX_V7_LPBIG_OFFBIG_CFLAGS, "POSIX_V7_LPBIG_OFFBIG_CFLAGS" },
> +	{ _CS_POSIX_V7_LPBIG_OFFBIG_LDFLAGS, "POSIX_V7_LPBIG_OFFBIG_LDFLAGS" },
> +	{ _CS_POSIX_V7_LPBIG_OFFBIG_LIBS, "POSIX_V7_LPBIG_OFFBIG_LIBS" },
> +#ifdef _CS_POSIX_V7_THREADS_CFLAGS
> +	{ _CS_POSIX_V7_THREADS_CFLAGS, "POSIX_V7_THREADS_CFLAGS" },
> +#endif
> +#ifdef _CS_POSIX_V7_THREADS_LDFLAGS
> +	{ _CS_POSIX_V7_THREADS_LDFLAGS, "POSIX_V7_THREADS_LDFLAGS" },
> +#endif
> +	{ _CS_POSIX_V7_WIDTH_RESTRICTED_ENVS, "POSIX_V7_WIDTH_RESTRICTED_ENVS" },
> +#ifdef _CS_V7_ENV
> +	{ _CS_V7_ENV, "V7_ENV" },
>  #endif

This looks fine and as long as it compiles on supported distros and
compilers:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Btw, we can simplify the code a bit with macro like:

#define PAIR(name) {_CS_ ## name, #name}

>  };
>  
> -- 
> 2.35.3
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz