[LTP] [PATCH 1/2] tst_test.sh: Cleanup getopts usage

Petr Vorel pvorel@suse.cz
Fri Apr 22 11:23:06 CEST 2022


Hi all,

Martin spotted another error in zram01: setup() function in zram01.sh was not
called due being overwritten in zram_lib.sh. Replaced with conditional
expansion.

In case anybody wants to test this latest version is branch
tst_test.sh/cleanup-getopts.fixes in my fork:
https://github.com/pevik/ltp/commits/tst_test.sh/cleanup-getopts.fixes

Kind regards,
Petr

diff --git testcases/kernel/device-drivers/zram/zram_lib.sh testcases/kernel/device-drivers/zram/zram_lib.sh
index f2280334e8..6ce2ff1d4f 100755
--- testcases/kernel/device-drivers/zram/zram_lib.sh
+++ testcases/kernel/device-drivers/zram/zram_lib.sh
@@ -12,7 +12,7 @@ sys_control=-1
 
 TST_NEEDS_TMPDIR=1
 TST_NEEDS_ROOT=1
-TST_SETUP="zram_load"
+TST_SETUP="${TST_SETUP:-zram_load}"
 TST_CLEANUP="zram_cleanup"
 TST_NEEDS_DRIVERS="zram"
 


More information about the ltp mailing list