[LTP] [PATCH v2 3/4] tst_test.sh: Cleanup getopts usage

[Martin Doucha]

Hi,
the patch looks mostly good except for a few issue below.

On 22. 04. 22 16:41, Petr Vorel wrote:
> diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh
> index a80fbe7fa7..673e6f8029 100755
> --- a/testcases/kernel/device-drivers/zram/zram01.sh
> +++ b/testcases/kernel/device-drivers/zram/zram01.sh
> @@ -151,4 +151,5 @@ do_test()
>  	esac
>  }
>  
> +. zram_lib.sh

zram_lib.sh appears to be imported twice here after the setup/cleanup fixes.

>  tst_run
> diff --git a/testcases/network/rpc/basic_tests/rup/rup01.sh b/testcases/network/rpc/basic_tests/rup/rup01.sh
> index 44f0e73d26..dd0e71be7a 100755
> --- a/testcases/network/rpc/basic_tests/rup/rup01.sh
> +++ b/testcases/network/rpc/basic_tests/rup/rup01.sh
> @@ -19,7 +19,6 @@ TCID="rup01"
>  TST_TOTAL=7
>  
>  TST_USE_LEGACY_API=1
> -. tst_net.sh

The tst_net.sh import got completely dropped in this file likely because
there's no call to tst_run(). Instead, the test calls do_setup(),
do_test() and tst_exit() directly.

>  
>  do_setup()
>  {
> diff --git a/testcases/network/rpc/basic_tests/rusers/rusers01.sh b/testcases/network/rpc/basic_tests/rusers/rusers01.sh
> index 554bfa01cf..8fef5757e1 100755
> --- a/testcases/network/rpc/basic_tests/rusers/rusers01.sh
> +++ b/testcases/network/rpc/basic_tests/rusers/rusers01.sh
> @@ -19,7 +19,6 @@ TCID="rusers01"
>  TST_TOTAL=5
>  
>  TST_USE_LEGACY_API=1
> -. tst_net.sh

Same here.

>  
>  do_setup()
>  {

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic