[LTP] [PATCH v3 1/5] busy_poll_lib.sh: Mention setup/cleanup defined in tests

[Martin Doucha]

Hi,

On 27. 04. 22 14:49, Petr Vorel wrote:
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> New in v3
> 
>  testcases/network/busy_poll/busy_poll_lib.sh | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/network/busy_poll/busy_poll_lib.sh b/testcases/network/busy_poll/busy_poll_lib.sh
> index d17504466..69e590031 100755
> --- a/testcases/network/busy_poll/busy_poll_lib.sh
> +++ b/testcases/network/busy_poll/busy_poll_lib.sh
> @@ -1,10 +1,14 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (c) Linux Test Project, 2016-2022
>  # Copyright (c) 2016-2018 Oracle and/or its affiliates. All Rights Reserved.
>  
> -TST_SETUP="setup"
>  TST_TESTFUNC="test"
> +
> +# setup and cleanup defined in tests using this library

Hooking up callbacks on the reverse end of include is some seriously
dirty code. I'd recommend dropping this patch and then making a separate
patchset to move those TST_SETUP/TST_CLEANUP variables out of the library.

> +TST_SETUP="setup"
>  TST_CLEANUP="cleanup"
> +
>  TST_MIN_KVER="3.11"
>  TST_NEEDS_TMPDIR=1
>  TST_NEEDS_ROOT=1


-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic