[LTP] [PATCH v3 5/5] busy_poll: Move TST_{SETUP, CLEANUP} to the tests

Petr Vorel pvorel@suse.cz
Fri Apr 29 20:09:29 CEST 2022


Hi Martin,

> Hi,
> TST_TESTFUNC should be moved to individual test scripts as well, for the
> same reason. Other than that, the whole patchset looks good:

I was thinking about it as well. Makes sense, but then it hides the fact that
busy_poll_lib.sh contain other API variables (missing TST_TESTFUNC suggest that
there are some variables in busy_poll_lib.sh). Anyway, I'm ok to move it there
as well, just document that sharing variables between library and test will be
always a bit problematic.

> Reviewed-by: Martin Doucha <mdoucha@suse.cz>

Thanks!

Kind regards,
Petr


More information about the ltp mailing list