[LTP] [PATCH 2/2] lapi/fsmount: resolve conflict in different header files

Li Wang liwang@redhat.com
Fri Aug 5 11:44:07 CEST 2022


Hi Petr,

On Fri, Aug 5, 2022 at 3:38 PM Petr Vorel <pvorel@suse.cz> wrote:

> Hi Li,
>
> > The latest glibc added new wrappers (e.g. mount_setattr, fsopen) support
> in
> > sys/mount.h, which partly conflicts with linux/mount.h at the same time.
>
> > We need to make adjustments to header files to fix compiling error on
> > different platforms.
> thanks for fixing this!
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> LGTM, with suggestion.
>
> > +#include <sys/mount.h>
> >  #include "tst_test.h"
> >  #include "lapi/fsmount.h"
> How about instead adding it to the tests to add it to lapi/fsmount.h ?


It's weird, I was unable to compile successfully like this way yesterday.
So finally go by one by one including the header.

But after doing `make distclean` it works now, I guess there is probably
something messes up my source directory.

Anyway, thanks for your quick review, will merge soon.


-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220805/bf9ebe92/attachment.htm>


More information about the ltp mailing list