[LTP] [PATCH v5] Refactor aiocp using new LTP API

Andrea Cervesato andrea.cervesato@suse.com
Wed Aug 10 09:00:29 CEST 2022


Today I send the new patch. Thanks for the review


On 8/10/22 08:57, Petr Vorel wrote:
> Hi Andrea, Cyril,
>> Hi!
>> The code looks good now, but still needs a runtime treatement similar to
>> the one done in 3ab0b3cb24198a0a833e4450b8bc9cee8b70baf6.
> OK, new version is needed. When you're in it, could you please consider things
> Cyril asked in v1? [1]
> * rename functions
> 	I guess that it would be cleaner to rename the functions to something as
> 	put_iocb() and get_iocb() since they do not allcate anything but they
> 	have to stay.
> * I suppose later you implement ioctl() BLKSZGET
> 	> -static int dev_block_size_by_path(const char *path)
> 	Just FYI this is actually the only correct way how to get the O_DIRECT
> 	block size, we have to get the device and then call the BLKSZGET
> 	ioctl(). This code has to be put into the test library and reused in all
> 	O_DIRECT tests in a followup patch.
> Kind regards,
> Petr
> [1] https://patchwork.ozlabs.org/comment/2917667/

More information about the ltp mailing list