[LTP] [PATCH v4 1/4] tst_test.sh: runtest.sh: Remove unused code

Martin Doucha mdoucha@suse.cz
Wed Aug 10 17:03:58 CEST 2022


Hi,
looks good.

Reviewed-by: Martin Doucha <mdoucha@suse.cz>

On 08. 08. 22 13:37, Petr Vorel wrote:
> This code is in tst_print_colored() (probably forgotten to remove code
> from tst_test.sh in a7f613372 when moved to tst_print_colored during
> development; later copy wrong code in d132084bc into runtest.sh).
> 
> Fixes: a7f613372 ("Colorize test type in the output")
> Fixes: d132084bc ("lib: Add script for running tests")
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  lib/newlib_tests/runtest.sh | 3 ---
>  testcases/lib/tst_test.sh   | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/lib/newlib_tests/runtest.sh b/lib/newlib_tests/runtest.sh
> index f136bcb88..e78b556c5 100755
> --- a/lib/newlib_tests/runtest.sh
> +++ b/lib/newlib_tests/runtest.sh
> @@ -48,9 +48,6 @@ runtest_res()
>  	local res="$1"
>  	shift
>  
> -	tst_color_enabled
> -	local color=$?
> -
>  	printf "runtest " >&2
>  	tst_print_colored $res "$res: " >&2
>  	echo "$@" >&2
> diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
> index a35fa2e7b..356af0106 100644
> --- a/testcases/lib/tst_test.sh
> +++ b/testcases/lib/tst_test.sh
> @@ -112,9 +112,6 @@ tst_res()
>  	local res=$1
>  	shift
>  
> -	tst_color_enabled
> -	local color=$?
> -
>  	_tst_inc_res "$res"
>  
>  	printf "$TST_ID $TST_COUNT " >&2


-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic


More information about the ltp mailing list