[LTP] [PATCH v4 3/4] tst_test.sh: Fix _tst_cleanup_timer() on set -e

Petr Vorel pvorel@suse.cz
Thu Aug 11 10:08:58 CEST 2022


> On 10. 08. 22 18:29, Petr Vorel wrote:
> > Hi Martin,

> >> Hi,
> >> a comment explaining why this is needed would be nice, otherwise looks
> >> good. For patches 2 and 3:

> >> Reviewed-by: Martin Doucha <mdoucha@suse.cz>

> >> On 08. 08. 22 13:37, Petr Vorel wrote:
> >>> If test exits on time (i.e. no timeout) kill in _tst_cleanup_timer()
> >>> have nothing to kill therefore following wait exits 143.
> > I thought this is the explanation. Or would you prefer anything else to add?

> The commit message will get buried deep in Git history. It's better to
> comment this in the code because it's not obvious why the "|| true" is
> needed after "wait ..."
Ah, didn't get "comment" means comment in the code. Makes sense, thx!

Kind regards,
Petr


More information about the ltp mailing list