[LTP] [PATCH 2/2] tst_rod: Fail on directory change commands

Petr Vorel pvorel@suse.cz
Tue Aug 16 14:51:46 CEST 2022


> Hi!
> > Beware that this patch will cause a lot of broken shell tests to fail.
> > Another patchset fixing the incorrect ROD usage in shell tests is needed
> > before merging this patch.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

I also wonder if we should care for pushd/popd which are bashism and should not
be used in LTP tests which use new shell API.

So far they are used in testcases/realtime/run.sh testscripts/test_realtime.sh,
which does not use shell API (and realtime should be removed after porting
anything useful to rt-tests).

> The only broken test I've found is du01.sh that does
> "ROD_SILENT cd basedir" are there actually any other tests that does so?

Indeed it looks just du01.sh.

Kind regards,
Petr


More information about the ltp mailing list