[LTP] [PATCH 1/4] lib: Fix initialization of recursive mutex
Tudor Cretu
tudor.cretu@arm.com
Wed Aug 17 15:39:43 CEST 2022
For any libc that doesn't define PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP,
don't assume that the type of the mutex is the first member. Use a
runtime initializer instead.
Signed-off-by: Tudor Cretu <tudor.cretu@arm.com>
---
lib/tst_res.c | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/lib/tst_res.c b/lib/tst_res.c
index 8d86b48a4..2f66ec40c 100644
--- a/lib/tst_res.c
+++ b/lib/tst_res.c
@@ -82,17 +82,27 @@ void *TST_RET_PTR;
assert(strlen(buf) > 0); \
} while (0)
-#ifndef PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP
-# ifdef __ANDROID__
-# define PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP \
- PTHREAD_RECURSIVE_MUTEX_INITIALIZER
-# else
-/* MUSL: http://www.openwall.com/lists/musl/2017/02/20/5 */
-# define PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP { {PTHREAD_MUTEX_RECURSIVE} }
-# endif
+#if !defined(PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP) && defined(__ANDROID__)
+#define PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP PTHREAD_RECURSIVE_MUTEX_INITIALIZER
#endif
+#ifdef PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP
static pthread_mutex_t tmutex = PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP;
+#else
+/* MUSL: http://www.openwall.com/lists/musl/2017/02/20/5 */
+static pthread_mutex_t tmutex;
+
+__attribute__((constructor))
+static void init_tmutex(void)
+{
+ pthread_mutexattr_t mutattr = {0};
+
+ pthread_mutexattr_init(&mutattr);
+ pthread_mutexattr_settype(&mutattr, PTHREAD_MUTEX_RECURSIVE);
+ pthread_mutex_init(&tmutex, &mutattr);
+ pthread_mutexattr_destroy(&mutattr);
+}
+#endif
static void check_env(void);
static void tst_condense(int tnum, int ttype, const char *tmesg);
--
2.25.1
More information about the ltp
mailing list