[LTP] [PATCH 1/1] statx04: Remove kernel comments in docparse

xuyang2018.jy@fujitsu.com xuyang2018.jy@fujitsu.com
Fri Aug 19 16:10:33 CEST 2022


Hi Li

>     So for me, If remove kernel commit in description, then I only see
>     useless commit id number, unless I go to search them in kernel org.
> 
> 
> Not exactly, another thing to make people's attention is test fail with 
> hint,
> then we can simply click the link.

I remember Amir also added a similar feature[1] to xfstests when he 
become xfs 5.10 stable kernel maintainer.

So maybe we can add a third colume in tst_test struct's tag field  to 
cover kernel commit title? Then this kernel comment can be removed.

Also, I don't have strong obejection to this patch because it seems 
duplicate, but I just want to keep kernel commit title by using simple way.

[1]https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?id=4fb72cffd9e3251149d9fa25daa96b2e26b62eab

Best Regards
Yang Xu
> 

>      58	HINT: You _MAY_ be missing kernel fixes:
>      59	
>      60	https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93bc420ed41d  <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93bc420ed41d>
>      61	https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=99652ea56a41  <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=99652ea56a41>
>      62	https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=04a87e347282  <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=04a87e347282>  
>      63https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5f955f26f3d4  <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5f955f26f3d4>
> 
> 
> -- 
> Regards,
> Li Wang


More information about the ltp mailing list