[LTP] [PATCH] syscalls/fanotify10: Make evictable marks test more reliable

[Petr Vorel]

> On Fri, Aug 26, 2022 at 5:19 PM Jan Kara <jack@suse.cz> wrote:

> > On Fri 26-08-22 15:12:14, Petr Vorel wrote:
> > > Hi Jan, all,

> > > > In some setups evictable marks tests are failing because the inode with
> > > > evictable mark does not get evicted. Make sure we sync the filesystem
> > > > before we try to drop caches to increase likelyhood the inode will get
> > > > evicted.

> > > Merged with minor changes to keep checkpatch.pl happy.

> > Thanks!

> > > Given on previous discussion the behavior on ext2 vs. xfs:
> > > would it make sense to transform the test to use .all_filesystems = 1 ?

> On the contrary.
> We want the inode reclaim to be as predictable as possible.
> That is why I suggested to force the test to use ext2
> because xfs has some specialized inode reclaim

Ah right! Could you please send a patch with .dev_fs_type = "ext2"
That should be enough I guess.


> > Well, I don't think it would improve test coverage in any interesting way.
> > This test tests stuff in fsnotify layer & VFS. The differences in
> > filesystem inode reclaim are not target of this test - we are just trying
> > to check that fsnotify does not block inode reclaim by holding inode
> > references and for that any filesystem works. Or did you mean something
> > else?


> Agree. I see no reason to change that.

Thank you both for info!

Kind regards,
Petr

> Thanks,
> Amir.