[LTP] [PATCH 2/6] API: tst_device: Track minimal size per filesystem

Li Wang liwang@redhat.com
Tue Aug 30 08:11:25 CEST 2022


Cyril Hrubis <chrubis@suse.cz> wrote:


>
> > +             return MAX(DEV_SIZE_MB_BTRFS, DEV_SIZE_MB_DEFAULT);
>
> I do not think that we should harcode this here. I would be for a more
> dynamic approach, i.e. add a function into the tst_supported_fs_types.c
> that loops over supported filesystems and chooses max over the minimal
> values for all supported filesystems. That way if we run on embedded
> targets the device size will be 16MB as long as btrfs-progs is not
> installed. Also that way we can easily define minimal size for xfs 300MB
> and things will work for embedded as long as xfs-progs are not
> installed.
>

+1 this is a quite good suggestion that solved what we were concerned about
different XFS code paths.

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220830/a0470600/attachment.htm>


More information about the ltp mailing list