Hi! > +enum tst_fill_access_pattern { > + TST_FILL_FLAT_VEC, Not sure if this is a good name, maybe TST_FILL_BLOCKS or TST_FILL_PAGES. > + TST_FILL_RANDOM > +}; Otherwise the whole patchset looks good to me. Reviewed-by: Cyril Hrubis <chrubis@suse.cz> -- Cyril Hrubis chrubis@suse.cz