[LTP] [PATCH v2] syscalls/brk: add direct syscall tst_variant

Teo Couprie Diaz teo.coupriediaz@arm.com
Wed Dec 14 11:03:25 CET 2022


Hi Petr,

On 13/12/2022 19:00, Petr Vorel wrote:
> Hi Teo,
>
> ...
>>> Looking on extra brk() support detection, you must have tested it on Alpine.
>>> What am I missing?
>> That is quite strange indeed. As Richard pointed out in his reply to this
>> message, those warnings should not happen anymore since my patch that
>> changed tst_syscall to use intptr_t. ( e5d2a05a90e5 : regen.sh: Use intptr_t
>> for tst_syscall return )
>> However, I believe that the relevant header is only regenerated when running
>> ./configure , not when building normally. I know that I forgot to do it a
>> few times myself while testing the change to tst_syscall !
>> To be sure that it is supposed to work, I did the following on an Alpine VM
>> I used for testing :
>> make clean
>> make autotools
>> ./configure
> I'm sorry to forget basic LTP things. Setup was really old, thus rerunning
> configure was needed.
> No more objections from my side, merged with changes I previously posted
> (to keep checks happy).
That makes sense, no worries !
>
> Thank you!
>
> Kind regards,
> Petr
Thanks for the thorough review and testing !
Kind regards,
Téo


More information about the ltp mailing list