[LTP] [PATCH v3 3/7] cgroup_regression_test.sh: Remove obselte test_6
xuyang2018.jy@fujitsu.com
xuyang2018.jy@fujitsu.com
Fri Dec 16 10:11:44 CET 2022
Hi Petr
>> test_6 is a test case when kernel version is less than 3.0.
>> Since the oldest supported kernel version is 3.0, so the case
>> is useless. Remove it.
>
> Acked-by: Petr Vorel <pvorel@suse.cz>
>
>> Also rename test9 to test6. modify TST_CNT.
> I wonder if rename is a good thing to do, because it complicates git history.
> I'd keep old names.
> Also in the past we didn't rename, e.g. in 1c44244849 ("getuid, getgid, setuid,
> setgid: fixed 16-bit versions")
> testcases/kernel/syscalls/getuid/getuid02.c was renamed to
> testcases/kernel/syscalls/geteuid/geteuid02.c to match the new test coverage,
> but testcases/kernel/syscalls/getuid/getuid03.c stayed the same (not renamed to
> testcases/kernel/syscalls/getuid/getuid02.c, which was then free).
>
> Or maybe better example: testcases/kernel/syscalls/kill/kill01.c got deleted
> in eafdc5dd83 ("syscalls/kill01: Remove it"), but test names did not shift.
I can understand, but I used the same renamed way because we did this
case for test_5 in 2019[1].
[1]https://github.com/linux-test-project/ltp/commit/9b8f841ced26cd0d19dc9a007d0efd941929abde
Best Regards
Yang Xu
>
> Kind regards,
> Petr
More information about the ltp
mailing list