[LTP] [PATCH v3 2/5] API/cgroup: Declare required controllers and version in test struct

Li Wang liwang@redhat.com
Tue Feb 8 10:24:03 CET 2022


> > What about declaring as 'tst_cgroup_test' ? i.e.
> >
> >     const struct tst_cgroup_group *const tst_cgroup_test = &test_group;
> >
> > As it is a reference to test's CGroup and the test_dir is the same
> > layer with drain_dir, so this will be easier to understand the
> relationship
> > with drain_group.
> >
> >  +const struct tst_cgroup_group *const tst_cgroup_drain =
> >  &drain_group;
>
> I agree with your logic, but the variable name is too long even without
> '_test'. Perhaps we could shorten cgroup to cg? However I can submit a
> separate patch for that.
>

Ok, I agree with shortening that. Thanks!


-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220208/27fc35a1/attachment.htm>


More information about the ltp mailing list