[LTP] [PATCH v1] mem/swapping01: Make sure swap is supported by kernel

xuyang2018.jy@fujitsu.com xuyang2018.jy@fujitsu.com
Fri Feb 11 09:30:13 CET 2022


Hi Bogdan
> Hi all,
>
> I didn't go for CONFIG_SWAP just because wanted to be aligned with
> syscalls/swapon/swapon03.c and to not multiply patterns.
>
> If you see CONFIG_SWAP more beneficial for docparser, I can make another
> patch.
>
> Should I?
IMO, yes, but let's listen voice from other maintainers.
@Petr,@Cyril

Best Regards
Yang Xu
>
> Cheers,
> Bogdan
> ------------------------------------------------------------------------
> *From:* ltp <ltp-bounces+bogdan.lezhepekov=suse.com@lists.linux.it> on
> behalf of xuyang2018.jy@fujitsu.com <xuyang2018.jy@fujitsu.com>
> *Sent:* Friday, February 11, 2022 3:21
> *To:* Li Wang <liwang@redhat.com>
> *Cc:* LTP List <ltp@lists.linux.it>
> *Subject:* Re: [LTP] [PATCH v1] mem/swapping01: Make sure swap is
> supported by kernel
> Hi Li
>>
>>
>>  On Fri, Feb 11, 2022 at 12:09 AM Cyril Hrubis <chrubis@suse.cz
>>  <mailto:chrubis@suse.cz>> wrote:
>>
>>  Hi!
>>  Applied, thanks.
>>
>>  I guess that the SAFE_OPEN() caused TBROK on machines without
>>  CONFIG_SWAP, right?
>>
>>
>>  If so, why not go fix with .needs_config for "CONFIG_SWAP=y" ?
> +1, it is also friendly to docparse.
>
> ps: I never listen user complaint for the lack of CONFIG_PORC, so only
> using .needs_config for "CONFIG_SWAP=y" can work well.
>
> Best Regards
> Yang Xu
>>
>>  --
>>  Regards,
>>  Li Wang
>>
>>
>>
>>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>


More information about the ltp mailing list