[LTP] [PATCH] test_children_cleanup.sh: Fix race condition
Martin Doucha
mdoucha@suse.cz
Mon Feb 14 17:51:29 CET 2022
Processes can stay alive for a short while even after receiving SIGKILL.
Give the child in subprocess cleanup libtest up to 5 seconds to fully exit
before reporting that it was left behind.
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
lib/newlib_tests/test_children_cleanup.sh | 21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/lib/newlib_tests/test_children_cleanup.sh b/lib/newlib_tests/test_children_cleanup.sh
index 4b4e8b2f0..44505aa51 100755
--- a/lib/newlib_tests/test_children_cleanup.sh
+++ b/lib/newlib_tests/test_children_cleanup.sh
@@ -10,10 +10,19 @@ rm "$TMPFILE"
if [ "x$CHILD_PID" = "x" ]; then
echo "TFAIL: Child process was not created"
exit 1
-elif ! kill -s 0 $CHILD_PID &>/dev/null; then
- echo "TPASS: Child process was cleaned up"
- exit 0
-else
- echo "TFAIL: Child process was left behind"
- exit 1
fi
+
+# The child process can stay alive for a short while even after receiving
+# SIGKILL, especially if the system is under heavy load. Wait up to 5 seconds
+# for it to fully exit.
+for i in `seq 6`; do
+ if ! [ -e "/proc/$CHILD_PID" ]; then
+ echo "TPASS: Child process was cleaned up"
+ exit 0
+ fi
+
+ sleep 1
+done
+
+echo "TFAIL: Child process was left behind"
+exit 1
--
2.34.1
More information about the ltp
mailing list