[LTP] [PATCH v3 2/4] lib: Introduce KCONFIG_SKIP_CHECK environment variable
xuyang2018.jy@fujitsu.com
xuyang2018.jy@fujitsu.com
Tue Jan 11 02:38:12 CET 2022
Hi Cyril
> Hi!
>> This environment variable is designed to add kernel config check functionality
>> switch. So we can skip kconfig check completely and it is useful especially
>> for the embedded platforms that they don't have kernel config.
>>
>> Signed-off-by: Yang Xu<xuyang2018.jy@fujitsu.com>
>> ---
>> doc/user-guide.txt | 1 +
>> lib/tst_kconfig.c | 20 ++++++++++++++++++++
>> lib/tst_test.c | 1 +
>> 3 files changed, 22 insertions(+)
>>
>> diff --git a/doc/user-guide.txt b/doc/user-guide.txt
>> index 494652618..864467f60 100644
>> --- a/doc/user-guide.txt
>> +++ b/doc/user-guide.txt
>> @@ -10,6 +10,7 @@ For running LTP network tests see `testcases/network/README.md`.
>> |==============================================================================
>> | 'KCONFIG_PATH' | The path to the kernel config file, (if not set, it tries
>> the usual paths '/boot/config-RELEASE' or '/proc/config.gz').
>> +| 'KCONFIG_SKIP_CHECK' | Skip kernel config check, the default is empty(don't skip).
> ^
> Space
> here
> please
>> | 'LTPROOT' | Prefix for installed LTP, the default is '/opt/ltp'.
>> | 'LTP_COLORIZE_OUTPUT' | Force colorized output behaviour. 'y' or '1': always colorize
>> 'n' or '0': never colorize.
>> diff --git a/lib/tst_kconfig.c b/lib/tst_kconfig.c
>> index 7d7aecfc1..e4264101d 100644
>> --- a/lib/tst_kconfig.c
>> +++ b/lib/tst_kconfig.c
>> @@ -15,6 +15,16 @@
>> #include "tst_kconfig.h"
>> #include "tst_bool_expr.h"
>>
>> +static int kconfig_check_skipped(void)
> ^
> I would have named this same as the variable,
> i.e. kconfig_skip_check()
Will fix these two comments in v5, thanks for your review.
Best Regards
Yang Xu
>
> Other that these two minor things:
>
> Reviewed-by: Cyril Hrubis<chrubis@suse.cz>
>
More information about the ltp
mailing list