[LTP] [PATCH 1/1] utime03.c: Fix filesystem name

[Li Wang]

On Mon, Jan 17, 2022 at 5:04 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> Hi Li, Cyril,
>
> > > > +++ b/testcases/kernel/syscalls/utime/utime03.c
> > > > @@ -93,7 +93,7 @@ static struct tst_test test = {
> > > >         .mntpoint = MNTPOINT,
> > > >         .all_filesystems = 1,
> > > >         .skip_filesystems = (const char *const[]) {
> > > > -               "v9",
> > > > +               "9p",
>
> > > I'm wondering does it really take effect with whatever "v9" or "9p"?
> > > Because the fs_type_whitelist[] does not include any of them.
> +1. Do we want to add 9p to fs_type_whitelist[]? I suppose not, because (despite

I agree with you, as 9p is not a widely used filesystem for Linux distribution.

> of the name containing "whitelist" it's the list of filesystems actually being
> tested - this is a bit confusing to me).

Yes, it is actually the filesystem list that LTP will be tested on.
or maybe rename it to better understand.

>
> > Unless removing the .all_filesystems as well otherwise, it is impossible
> > has a chance to test on 9p.
> Yep. I forgot that .skip_filesystems works also on single fs.
> So correct entry in .skip_filesystems is kind of documentation in case of
> .all_filesystems being removed. I guess we should just remove the entry.

Sorry, what does that 'remove the entry' mean? I didn't catch your point here.

--
Regards,
Li Wang