[LTP] [PATCH] Rewrite statx04 test
Petr Vorel
pvorel@suse.cz
Wed Jan 19 11:55:33 CET 2022
Hi Martin,
> statx04 is supposed verify that inode attribute support in statx() matches
> what should actually be implemented. However, we already have functional tests
> for this in statx08 and lack a test of the stx_attribute_mask field which
> reports inode attribute support to userspace.
> Rewrite the test to drop the duplicate code and add the missing coverage.
LGTM, thanks! BTW you'd deserve your (or SUSE) copyright for this change :).
Reviewed-by: Petr Vorel <pvorel@suse.cz>
...
> * xfs filesystem doesn't support STATX_ATTR_COMPRESSED flag, so we only test
> * three other flags.
I'd maybe add "known-fail" for xfs, as user hit this when running -s.
Maybe document like this also btrfs.
Kind regards,
Petr
More information about the ltp
mailing list