[LTP] [PATCH v2] Rewrite statx04 test

Martin Doucha mdoucha@suse.cz
Wed Jan 19 12:28:00 CET 2022


On 19. 01. 22 12:23, Petr Vorel wrote:
> Hi Martin,
> 
>> ...
> 
> I'd put this into commit message (can be done during merge).

Sure.

>> +	for (i = 0, expected_mask = 0; i < ARRAY_SIZE(attr_list); i++)
> Before merge we should cast to prevent "comparison of integer expressions of
> different signedness" warning:
> for (i = 0, expected_mask = 0; i < (int)ARRAY_SIZE(attr_list); i++)

It's better to fix that by changing the type of "i" to size_t or
unsigned int. But GCC could easily deduce that one of the values is a
constant well within the range of signed int and not bother us with the
warning...

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic


More information about the ltp mailing list