[LTP] [PATCH v2] Rewrite statx04 test

[Li Wang]

Cyril Hrubis <chrubis@suse.cz> wrote:

> > +     /* STATX_ATTR_COMPRESSED not supported on XFS */
> > +     if (!strcmp(tst_device->fs_type, "xfs"))
> > +             expected_mask &= ~STATX_ATTR_COMPRESSED;

...
> > +     .skip_filesystems = (const char *const[]) {
> > +             "fuse",
> > +             NULL
> > +     },
> >       .tags = (const struct tst_tag[]) {
> >               {"linux-git", "93bc420ed41d"},
> >               {"linux-git", "99652ea56a41"},
> >               {"linux-git", "04a87e347282"},
> >               {"linux-git", "5f955f26f3d4"},
> > +             {"known-fail", "STATX_ATTR_COMPRESSED is not implemented on XFS (strict mode)"},

I'm wondering if it has necessary to add the known-fail tags here
since we have already done XFS filtering in setup().

> Otherwise I like the direction where this is going.
>
> I vote for merging this before the release with the TEST() and if()s

+1 fine to me, the rewrite looks pretty good if refine with reviewer's comments.

> replaced byt the TST_EXP_PASS() macro and we can decide where and how to
> put the strict knob later on.


-- 
Regards,
Li Wang