[LTP] [PATCH] configure: Fix summary for --disable-metadata
Petr Vorel
pvorel@suse.cz
Thu Jan 20 14:20:05 CET 2022
Hi Cyril,
> This changes the m4/ltp-docparse.m4 to skip the detection and sets the
> corresponding variables so that we get correct summary when the metadata
> are disable by users.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM, I'm for applying this before release.
./configure --disable-metadata-pdf --disable-metadata-html
...
configure: metadata generation disabled
...
METADATA
metadata generator: detect
HTML metadata: no
PDF metadata: no
=> this case is not handled well. Output during configure ("metadata generation
disabled") is IMHO more descriptive than our summary - "detect" can be confusing
for people. We could further tweak configure.ac:
@@ -43,6 +43,9 @@ fi
if test "x$enable_metadata_html" = xyes -o "x$enable_metadata_pdf" = xyes; then
AX_PROG_PERL_MODULES(Cwd File::Basename JSON LWP::Simple)
+else
+ with_metadata=no
+ with_metadata_generator=none
fi
---
=> would lead to:
METADATA
metadata generator: none
HTML metadata: no
PDF metadata: no
But instead of that I'd also adjusted the summary to print "metadata disabled"
to reflect the reality, i.e. apply also my patch
https://lore.kernel.org/ltp/20220114125513.895-1-pvorel@suse.cz/
Kind regards,
Petr
More information about the ltp
mailing list