[LTP] [PATCH] fstat02.c: simplify using TST_EXP_*() macros
Avinesh Kumar
akumar@suse.de
Fri Jul 8 19:06:34 CEST 2022
Simplifying the tests using TST_EXP_*() macros and removing the
unnecessary header includes
Signed-off-by: Avinesh Kumar <akumar@suse.de>
---
testcases/kernel/syscalls/fstat/fstat02.c | 59 ++++-------------------
1 file changed, 9 insertions(+), 50 deletions(-)
diff --git a/testcases/kernel/syscalls/fstat/fstat02.c b/testcases/kernel/syscalls/fstat/fstat02.c
index 2f9632edf..2142ae3e6 100644
--- a/testcases/kernel/syscalls/fstat/fstat02.c
+++ b/testcases/kernel/syscalls/fstat/fstat02.c
@@ -4,17 +4,14 @@
* 07/2001 Ported by Wayne Boyer
* 05/2019 Ported to new library: Christian Amann <camann@suse.com>
*/
-/*
+
+/*\ [Description]
+ *
* Tests if fstat() returns correctly and reports correct file information
* using the stat structure.
*/
-#include <errno.h>
-#include <unistd.h>
-#include <sys/stat.h>
-#include <sys/types.h>
#include "tst_test.h"
-#include "tst_safe_macros.h"
#define TESTFILE "test_file"
#define LINK_TESTFILE "link_test_file"
@@ -29,50 +26,12 @@ static int fildes;
static void run(void)
{
- int fail = 0;
-
- TEST(fstat(fildes, &stat_buf));
-
- if (TST_RET != 0) {
- tst_res(TFAIL | TTERRNO, "fstat() failed");
- return;
- }
-
- fail = 0;
- if (stat_buf.st_uid != user_id) {
- tst_res(TFAIL, "stat_buf.st_uid = %i expected %i",
- stat_buf.st_uid, user_id);
- fail++;
- }
-
- if (stat_buf.st_gid != group_id) {
- tst_res(TFAIL, "stat_buf.st_gid = %i expected %i",
- stat_buf.st_gid, group_id);
- fail++;
- }
-
- if (stat_buf.st_size != FILE_SIZE) {
- tst_res(TFAIL, "stat_buf.st_size = %li expected %i",
- (long)stat_buf.st_size, FILE_SIZE);
- fail++;
- }
-
- if ((stat_buf.st_mode & 0777) != FILE_MODE) {
- tst_res(TFAIL, "stat_buf.st_mode = %o expected %o",
- (stat_buf.st_mode & 0777), FILE_MODE);
- fail++;
- }
-
- if (stat_buf.st_nlink != NLINK) {
- tst_res(TFAIL, "stat_buf.st_nlink = %li expected %i",
- (long)stat_buf.st_nlink, NLINK);
- fail++;
- }
-
- if (fail)
- return;
-
- tst_res(TPASS, "fstat() reported correct values.");
+ TST_EXP_PASS(fstat(fildes, &stat_buf));
+ TST_EXP_EQ_LI(stat_buf.st_uid, user_id);
+ TST_EXP_EQ_LI(stat_buf.st_gid, group_id);
+ TST_EXP_EQ_LI(stat_buf.st_size, FILE_SIZE);
+ TST_EXP_EQ_LI(stat_buf.st_mode & 0777, FILE_MODE);
+ TST_EXP_EQ_LI(stat_buf.st_nlink, NLINK);
}
static void setup(void)
--
2.36.1
More information about the ltp
mailing list