[LTP] [RFC PATCH 1/1] creat09: Fix on more restrictive umask

[xuyang2018.jy@fujitsu.com]

on 2022/07/08 22:37, Christian Brauner wrote:
> On Thu, Jul 07, 2022 at 08:04:18PM +0200, Petr Vorel wrote:
>> Hi Xu,
>>
>>> Hi Petr
>>
>>> Share some process with you...
>>
>>> I have rejected this patch and a kernel patchset[1] is plan to fix this
>>> but doesn't merged to upstream kernel due to none continue to review
>>> this(It is about one month since v9...)
>>
>>> TBH, this case only tests simple creat file with open but miss
>>> open with O_TMPFILE[2]
>>> mknodat[3]
>>
>>> setgid strip logic is not only affected by umask but also include acl
>>> operations[4].
>>
>> Thanks a lot for an update.
>> Al, Christian, Amir, could you please have look on v9?
> 
> Afaict, I reviewed v9 and left comments and had pointed out things that
> needed to be changed. So I'd wait for v10 (I'm on vacation next week
> though.).

Oh, I missed that email and will think how to move logic into vfs_* as 
you suggested.

Best Regards
Yang Xu

> 
> Christian