[LTP] [PATCH] mount03: Convert to new API

[Richard Palethorpe]

Hello Petr,

Petr Vorel <pvorel@suse.cz> writes:

> Hi Chen,
>
> quite nice work, but more cleanup is needed.
>
>>  testcases/kernel/syscalls/mount/mount03.c | 462 ++++++++--------------
> ...
>>  #define FILE_MODE	(S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH)
>> -#define DIR_MODE	(S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP| \
>> -			 S_IXGRP|S_IROTH|S_IXOTH)
>>  #define SUID_MODE	(S_ISUID|S_IRUSR|S_IXUSR|S_IXGRP|S_IXOTH)
>
> @Richie @Li @Metan: There are checkpatch.pl warnings. Yes, kernel folks does not
> like permission warnings. Do we want to follow? Or should we remove these from
> our checkpatch.pl fork (we use constants in many places)?

I'm not sure about the rule. However there is no reason we can't follow
it for new tests. We don't want to have arbitrary style differences
between LTP and the kernel.

Some rules don't make sense in userland for technical reasons, but this
one is purely about readability.

-- 
Thank you,
Richard.