[LTP] [PATCH 1/2] syscalls/fanotify14: Encode the expected errno in test case

Amir Goldstein amir73il@gmail.com
Mon Jul 25 17:10:53 CEST 2022


On Mon, Jul 25, 2022 at 2:49 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> > On Tue, Jul 19, 2022 at 11:58:52AM +0200, Amir Goldstein wrote:
> > > So we can add test cases for errors other than EINVAL.
>
> > Just one optional nit. We can probably remove the comments which are
> > directly above the existing `if (errno == EINVAL)` checks as they're
> > specific to one expected errno value, but this is no longer the case
> > with ENOTDIR now in some fanotify_init/fanotify_mark cases.
>
> @Amir, I can remove it in this commit before merge (see diff below),
> but don't you want to keep this info somewhere?
> Or feel free to post new version.

Good idea.
I will add the comments to the individual test cases and re-post.

Thanks,
Amir.


More information about the ltp mailing list