[LTP] [PATCH v3 7/7] Rename common.h into mqns.h for mqns suite
Petr Vorel
pvorel@suse.cz
Tue Jul 26 09:00:19 CEST 2022
Hi Andrea,
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
> testcases/kernel/containers/mqns/{common.h => mqns.h} | 0
could you please also fix this checkpatch error (preferably as a separate patch):
mqns.h:37: ERROR: "foo* bar" should be "foo *bar"
mqns.h:96: WARNING: __func__ should be used instead of gcc specific __FUNCTION__
Checkpatch also reports wrong comment style, but I'd ignore it (complains for
*.h, it's ok for *.c):
mqns.h:1: WARNING: Improper SPDX comment style for 'mqns.h', please use '/*' instead
@Richie: not sure I might have asked before: it'd be great to have make target
also for header files, so that they are checked with make check. Now we have to
run checkpatch manually to check them.
Kind regards,
Petr
> testcases/kernel/containers/mqns/mqns_01.c | 2 +-
> testcases/kernel/containers/mqns/mqns_02.c | 2 +-
> testcases/kernel/containers/mqns/mqns_03.c | 2 +-
> testcases/kernel/containers/mqns/mqns_04.c | 2 +-
> 5 files changed, 4 insertions(+), 4 deletions(-)
> rename testcases/kernel/containers/mqns/{common.h => mqns.h} (100%)
...
Patch itself it's obviously correct.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
More information about the ltp
mailing list