[LTP] [PATCH 6/8] tst_test.sh: Add $TST_ALL_FILESYSTEMS

Petr Vorel pvorel@suse.cz
Wed Jun 1 10:41:55 CEST 2022


Hi Cyril,

...
> > +	[ "$TST_ALL_FILESYSTEMS" = 1 ] && TST_MOUNT_DEVICE=1
> >  	[ "$TST_MOUNT_DEVICE" = 1 ] && TST_FORMAT_DEVICE=1
> >  	[ "$TST_FORMAT_DEVICE" = 1 ] && TST_NEEDS_DEVICE=1
> >  	[ "$TST_NEEDS_DEVICE" = 1 ] && TST_NEEDS_TMPDIR=1

> > +	if [ "$TST_NEEDS_DEVICE" = 1 -a -z "$TST_MOUNT_FLAG" ]; then

> I do not get the TST_MOUNT_FLAG, what do we need it for? The tst_run()
> should be called exactly once in the test and at this point the
> TST_MOUNT_FLAG cannot be set.

Correct, $TST_MOUNT_FLAG should be removed here.
Thanks,
Petr

> > +		TST_DEVICE=$(tst_device acquire)
> > +
> > +		if [ ! -b "$TST_DEVICE" -o $? -ne 0 ]; then
> > +			unset TST_DEVICE
> > +			tst_brk TBROK "Failed to acquire device"
> > +		fi
> > +		TST_DEVICE_FLAG=1
> > +	fi



More information about the ltp mailing list