[LTP] [PATCH 1/5] syscalls/inotify12: Introduce test for inotify mask flags

Amir Goldstein amir73il@gmail.com
Mon Jun 13 18:03:56 CEST 2022


On Mon, Jun 13, 2022 at 6:23 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> Hi Amir,
>
> > > diff --git a/testcases/kernel/syscalls/inotify/inotify12.c b/testcases/kernel/syscalls/inotify/inotify12.c
> ...
> > > +static struct tst_test test = {
> > > +       .timeout = 10,
>
> > OOPS should be changed to .max_runtime = 10
>
> > > +       .needs_tmpdir = 1,
> > > +       .cleanup = cleanup,
> > > +       .test = verify_inotify,
> > > +       .tcnt = ARRAY_SIZE(tcases),
> > > +       .tags = (const struct tst_tag[]) {
> > > +               {"linux-git", "a32e697cda27"},
> > > +               {}
>
> > Missing }
>
> > Sorry, I hadn't notice this build failure before posting.
>
> No big deal, we can fix this before merge.
>
> And we have to try again to decide how to quickly merge tests for rc kernel.

Right.. forgot about that.
FWIW, the specific fix of test inotify12 is already in stable kernels
(v5.10.121, ...)

Thanks,
Amir.


More information about the ltp mailing list