[LTP] [PATCH v2] Fix mountns01/02/03/04 final umounts using more peculiar dir names

Cristian Marussi cristian.marussi@arm.com
Wed Jun 22 10:49:59 CEST 2022


On Wed, Jun 22, 2022 at 10:35:22AM +0200, Cyril Hrubis wrote:
> Hi!
> > >> --- a/testcases/kernel/containers/mountns/mountns.h
> > >> +++ b/testcases/kernel/containers/mountns/mountns.h
> > >> @@ -10,8 +10,8 @@
> > >>  #include "tst_test.h"
> > >>  #include "lapi/namespaces_constants.h"
> > >>  
> > >> -#define DIRA "A"
> > >> -#define DIRB "B"
> > >> +#define DIRA "__DIR_A"
> > >> +#define DIRB "__DIR_B"
> > > This is the only non-comment change. How does renaming the directories
> > > change anything? Am I missing something?
> > Nevermind, now after I read the v1-thread, I get it..
> 
> We tend to prefix globally visible objects with LTP_ in order to make
> them unique enough and that makes them clearly recognizable as being
> created by LTP as well. So maybe we should put the LTP string somewhere
> in the names too.
> 

Thanks Cyril for the review.
I'll do in v3.

Thanks,
Cristian


More information about the ltp mailing list