[LTP] [PATCH v2 04/16] API/cgroup: Implement tst_cgroup_load_config()

[Luke Nowakowski-Krijger]

Hi Richard and Li,

Sorry for the hiatus and the delay on getting this done. There was some
other stuff keeping me from finishing things up here.

On Mon, Jan 24, 2022 at 4:22 AM Richard Palethorpe <rpalethorpe@suse.de>
wrote:

> Hello Luke,
>
> Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com> writes:
>
> > Implement tst_cgroup_load_config which consumes the state given by
> > tst_cgroup_print_config() to update the internal test state to reflect
> > the given config.
> >
> > This allows for programs using the cgroup C API to load and reload
> > state, allowing functionality such as calling tst_cgroup_require and
> > tst_cgroup_cleanup to function properly between programs or between
> > invocations of a binary using the C API.
>
> I'm afraid I have to say this looks way more complicated than it needs
> to be. We control the input format after all.
>
> If you can make each line the same format then it may be possible to
> just use a single scanf on each line. Note that it's only possible to
> have ~14 controllers, so we can even afford to repeat the root info on
> each line.
>
>
I have read through all the feedback and I agree with all of it. I
implemented something along the lines of what you described here and I
agree that it looks a lot better and much much more simple. Hopefully get
that out to you soon to review.


> --
> Thank you,
> Richard.
>

Thanks,
Luke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220302/5cf67332/attachment.htm>