[LTP] [PATCH 1/3] quotactl06: Replace tst_brk(TFAIL) with TBROK

xuyang2018.jy@fujitsu.com xuyang2018.jy@fujitsu.com
Fri Mar 4 02:35:20 CET 2022


Hi Martin

Looks good to me,
Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>

Also, quotactl01 also use this similar code, I guess we can also replace
it. It seems we miss SAFE_ACCESS macro, we can add this macro and use it
in all similar code.

Best Regards
Yang Xu
> Signed-off-by: Martin Doucha<mdoucha@suse.cz>
> ---
>   testcases/kernel/syscalls/quotactl/quotactl06.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/quotactl/quotactl06.c b/testcases/kernel/syscalls/quotactl/quotactl06.c
> index 4fb198268..ca81a742f 100644
> --- a/testcases/kernel/syscalls/quotactl/quotactl06.c
> +++ b/testcases/kernel/syscalls/quotactl/quotactl06.c
> @@ -178,7 +178,7 @@ static void setup(void)
>   	set_dqmax.dqb_bsoftlimit = tst_variant ? 0x20000000000000 : 0x100000000;
> 
>   	if (access(USRPATH, F_OK) == -1)
> -		tst_brk(TFAIL | TERRNO, "user quotafile didn't exist");
> +		tst_brk(TBROK | TERRNO, "user quotafile didn't exist");
> 
>   	tst_require_quota_support(tst_device->dev, fmt_id, usrpath);
> 


More information about the ltp mailing list