[LTP] [PATCH 1/1] quotactl: Check for missing quota_v2 module

xuyang2018.jy@fujitsu.com xuyang2018.jy@fujitsu.com
Tue Mar 15 02:27:24 CET 2022


Hi Petr
> Hi Martin, Xu,
>
> I wonder whether quotactl04 still needs check for ESRCH search in do_mount()
> implemented by Martin in 4aab31e4c7 ("syscalls/quotactl: Skip tests if FS quota
> is not supported"), because that could be caught by CONFIG_QFMT_V2 and now
> quota_v2, right?
I think it is right.
>
> It uses fs_opts[] = {"-I 256", "-O quota,project", NULL} parameters for mkfs,
> thus it is probably needed.
If we format ext4 filesystem with quota feature, then the quota 
information will hidden in filesystem instead of visible file by using 
quotacheck.

But this feature needs mkfs > 1.43.0.

I guess we can remove do_mount by using SAFE_MOUNT like quotactl08 did.

Best Regards
Yang Xu

But shouldn't it be used also in quotactl08, which
> also uses fs_opts[] = { "-O quota", NULL} ?
>
> Kind regards,
> Petr


More information about the ltp mailing list