[LTP] [PATCH v2 1/8] Rewrite userns01.c using new LTP API
Petr Vorel
pvorel@suse.cz
Wed Mar 23 11:17:41 CET 2022
Hi Andrea,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
nit: I'd sometimes use underscore to make names more readable
i.e. update_map, parent_map_pid, OVERFLOW_UID_PATH, OVERFLOW_GID_PATH
> +static inline int check_newuser(void)
> +{
> + int pid, status;
> +
> + if (tst_kvercmp(3, 8, 0) < 0)
> + tst_brk(TCONF, "CLONE_NEWUSER not supported");
Is this limitation needed, when we have the same check with ltp_clone_quick()?
> +
> + pid = ltp_clone_quick(CLONE_NEWUSER | SIGCHLD, dummy_child, NULL);
> + if (pid == -1)
> + tst_brk(TCONF | TTERRNO, "CLONE_NEWUSER not supported");
> +
> + SAFE_WAIT(&status);
> +
> + return 0;
> +}
> +
> +static inline void updatemap(int cpid, bool type, int idnum, int parentmappid)
> +{
> + char path[BUFSIZ];
> + char content[BUFSIZ];
> + int fd;
> +
> + if (type == UID_MAP)
> + sprintf(path, "/proc/%d/uid_map", cpid);
> + else if (type == GID_MAP)
> + sprintf(path, "/proc/%d/gid_map", cpid);
> + else
> + tst_brk(TBROK, "invalid type parameter");
nit: maybe switch would be more readable.
...
Kind regards,
Petr
More information about the ltp
mailing list