[LTP] [PATCH v5] syscalls/umount2: Convert to new API and use SAFE_ACCESS
Petr Vorel
pvorel@suse.cz
Fri Mar 25 09:46:58 CET 2022
Hi Dai,
> v4->v5:
> - Add changelog from previous version
nit: You don't have mention in changelog that you're adding it.
(note anything after --- is not in the commit message)
> - Make commit message order more reasonable
> - Fix description format
> - Merge umount2.h into umount2_02
> - Use macro to not repeat flag and exp_errno
> - Make test_umount2() more compact
Thanks for implementing all this!
I merged it with few minor changes, added Xu's Reviewed-by: tag
(he reviewed v2 and v3).
...
> +++ b/testcases/kernel/syscalls/umount2/umount2_02.c
> +#define FLAG_DESC(x, y) .flag = x, .exp_errno = 0, .desc = "umount2("y") with "#x" expected success"
> +#define FLAG_EXP_ERRNO_DESC(x, y, z) .flag = x, .exp_errno = y, \
> + .desc = "umount2("z") with "#x" expected "#y
I cleaned whitespace here.
...
> + const char *mntpoint;
> + int do_access;
> +} tcases[] = {
> + {FLAG_EXP_ERRNO_DESC(MNT_EXPIRE | MNT_FORCE, EINVAL, ""), MNTPOINT, 0},
I removed blank lines in here.
...
> +static inline int umount2_retry(const char *target, int flags)
I removed this inline (required for *.h, but not needed here).
Kind regards,
Petr
More information about the ltp
mailing list