[LTP] [PATCH] syscalls/umount2_02: remove useless TST_ERR assignment

Petr Vorel pvorel@suse.cz
Mon Mar 28 09:12:22 CEST 2022


> Hi Petr,Dai
> > Hi Dai,

> >> Signed-off-by: Dai Shili<daisl.fnst@fujitsu.com>
> >> ---
> >>   testcases/kernel/syscalls/umount2/umount2_02.c | 1 -
> >>   1 file changed, 1 deletion(-)

> >> diff --git a/testcases/kernel/syscalls/umount2/umount2_02.c b/testcases/kernel/syscalls/umount2/umount2_02.c
> >> index 4c3b30e..d1aed11 100644
> >> --- a/testcases/kernel/syscalls/umount2/umount2_02.c
> >> +++ b/testcases/kernel/syscalls/umount2/umount2_02.c
> >> @@ -69,7 +69,6 @@ static int umount2_retry(const char *target, int flags)
> >>   	tst_res(TWARN, "Failed to umount('%s', %i) after 50 retries",
> >>   		target, flags);

> >> -	TST_ERR = EBUSY;

> > Not sure if the for loop in umount2_retry() could overwrite the original errno.
> IMO,  in this wrapper, we don't need to use TEST macro and we can use 
> umount2 directly.

+1

Kind regards,
Petr

> Best Regards
> Yang Xu

> > Kind regards,
> > Petr

> >>   	return -1;
> >>   }



More information about the ltp mailing list