[LTP] [PATCH v2 1/1] lib: Retry safe_clone() on ENOSPC|EUSERS

pvorel pvorel@suse.de
Wed Mar 30 14:46:49 CEST 2022


Hi Cyril, all,
>> 
>> NOTE: 0.1s seems to be safe, although using TST_RETRY_FUNC() with 1s
>> (the default) would be of course OK.
> 
> I would just put in the default 1s to make things extra safe even on
> slow hardware.
> 
+1
...
>> +/* too fast creating namespaces => retrying */
>> +#define TST_CHECK_ENOSPC(x) ((x) >= 0 || !(errno == ENOSPC || errno 
>> == EUSERS))
> 
> Reading the manual page I do not think that we have to retry on EUSERS,
> that used to be the return value where we reached limit of nested
> namespaces and that is not going go away if we retry.
> 
> Otherwise the rest looks good.
> 
Fixed both and merged.

Kind regards,
Petrb


More information about the ltp mailing list