[LTP] [PATCH 1/1] ksm: fix occasional page_volatile false positives

[Li Wang]

Andrea Arcangeli <aarcange@redhat.com> wrote:

The KSM scan keeps running while checking the KSM status in sysfs, but
> during the KSM scan the the rmap_items in the stale unstable tree of
> the old pass are removed from it and are later reinserted in the new
> unstable tree of the current pass, leading to some page_volatile
> false positives.
>
> The fix is stop the KSM scan temporarily while the KSM status is being
> read from sysfs.
>
> For reference here's an instance of the fixed false positives:
>
> mem.c:255: TFAIL: pages_volatile is not 0 but 1.
> mem.c:255: TFAIL: pages_unshared is not 1 but 0.
>
> Reported-by: Eirik Fuller <efuller@redhat.com>
> Co-developed-by: Li Wang <liwan@redhat.com>
> Tested-by: Li Wang <liwan@redhat.com>
>

This email address is valid but I prefer to use the my
name liwang@ for better remembering :).
(Anyway this doesn't matter, we can ignore this.)



> Tested-by: Eirik Fuller <efuller@redhat.com>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
>

Reviewed-by: Li Wang <liwang@redhat.com>

@Cryril, I vote for adding this patch in the new release.
Plz take this into consideration, thanks.


-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20220513/8a04993c/attachment.htm>