[LTP] [PATCH 0/2] Change return type of tst_syscall

Teo Couprie Diaz teo.coupriediaz@arm.com
Thu Nov 3 17:44:29 CET 2022


Hello LTP maintainers,

The goal of this patch is to fix a mismatch between the return type used in `tst_syscall`, `int`, and the one used by some syscalls, `long` or `void *` for example, which can be larger than an int and lead to an incorrect test.

As Cyril Hrubis' feedback on the RFC I sent earlier was mostly positive, I am now sending it as a patch proper. Thanks again for having a look !

The main change since the RFC is that the test suite I used for testing the change, specific to test that use tst_syscall, is now in a spearate commit which is not to be merged.
The point is to provide a reference to what was tested and what could be impacted.


CI build on latest master:
https://github.com/Teo-CD/ltp/actions/runs/3386567424

RFC patch on the mailing list archive:
https://lore.kernel.org/ltp/20221027163654.414017-1-teo.coupriediaz@arm.com/T/#m43e6a128019d94a215de33433f09e06f7734c9a2

Thank you in advance,
Téo Couprie Diaz

--
Teo Couprie Diaz (2):
  regen.sh: Use intptr_t for tst_syscall return
  [DO NOT MERGE] tst_syscall test suite

 include/lapi/syscalls/regen.sh |   2 +-
 runtest/check_tst_syscall      | 190 +++++++++++++++++++++++++++++++++
 2 files changed, 191 insertions(+), 1 deletion(-)
 create mode 100644 runtest/check_tst_syscall


base-commit: b606a7c7dc613b8041f7b3958695f2cdde04fbe5
-- 
2.25.1



More information about the ltp mailing list