[LTP] [PATCH] save_restore: Introduce new struct field for flags

Martin Doucha mdoucha@suse.cz
Thu Nov 10 17:00:08 CET 2022

On 03. 11. 22 17:45, Martin Doucha wrote:
> Tests using the .save_restore functionality currently cannot run
> without root privileges at all because the test will write
> into the path at least at the end and trigger error, even when
> the config paths are flagged as optional.
> Introduce new tst_path_val field for flags and replace path prefix flags
> with bit flags. Also introduce new flags to control handling of read/write
> errors and read-only sysfiles and rewrite save_restore implementation
> accordingly.
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
> This is technically a v2 for
> https://patchwork.ozlabs.org/project/ltp/patch/20221021155740.8339-1-mdoucha@suse.cz/
> I'll send a follow-up patchset to replace setup() code which requires root
> privileges without good reason after this patch gets merged. Here I've kept
> test changes to the minimum needed to maintain current save_restore behavior
> with the new flags system. The only change in behavior is the use of read-only
> handling flags where it's clear that the change is desired.
> Though a few tests should get closer attention during review:
> - all KSM tests
> - add_key05
> - migrate_pages02

Does anybody have any change requests? Or can we merge this so that I 
can send the follow-up patchset?

Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
Krizikova 148/34
186 00 Prague 8
Czech Republic

More information about the ltp mailing list