[LTP] [PATCH v2 1/3] save_restore: Introduce new struct field for flags

[Martin Doucha]

On 12. 11. 22 9:27, Li Wang wrote:
>       [source,c]
>       -------------------------------------------------------------------------------
>     -static void setup(void)
>     -{
>     -       FILE_PRINTF("/proc/sys/kernel/core_pattern", "/mypath");
>     -       SAFE_TRY_FILE_PRINTF("/proc/sys/user/max_user_namespaces",
>     "%d", 10);
>     -}
>     -
>       static struct tst_test test = {
>              ...
>              .setup = setup,
>              .save_restore = (const struct tst_path_val[]) {
>     -               {"/proc/sys/kernel/core_pattern", NULL},
>     -               {"?/proc/sys/user/max_user_namespaces", NULL},
>     -               {"!/sys/kernel/mm/ksm/run", "1"},
>     +               {"/proc/sys/kernel/core_pattern", NULL, 0},
>     +               {"/proc/sys/user/max_user_namespaces", NULL,
>     TST_SR_IF_ACCESS},
> 
> 
> This should be TST_SR_COND_ACCESS ^
> 
> Reviewed-by: Li Wang <liwang@redhat.com <mailto:liwang@redhat.com>>

Good catch. I noticed this mistake right before sending the patch, fixed 
it, exported a new patch, and then somehow sent the old patch anyway... 
*facepalm*

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic