[LTP] [PATCH v3] save_restore: Introduce new struct field for flags

[Martin Doucha]

On 14. 11. 22 14:25, Cyril Hrubis wrote:
> I'm not sure if it's a good idea to have default without any constants
> passed. When I look at the file_restore records in the tests it all
> makes sense until I reach a part where 0 is passed to the flags. I think
> that it would make sense to make everything as self describing as
> possible.
> 
> Would you consider adding TST_SR_TCONF_MISSING and TST_SR_TCONF_RO?

I could set both to 0, if that's OK.

>> +* 'TST_SR_FAIL_MISSING' – End test with 'TBROK' if the file does not exist
> 
> This FAIL part in this name is quite misleading since the test ends with
> TBROK. I would say that it would be much more clear if it was named
> TST_SR_TBROK_MISSING.

Then I should also rename TST_SR_REQUIRED to TST_SR_TBROK, rename 
TST_SR_COND_ACCESS to TST_SR_SKIP and add TST_SR_TCONF for the two new 
flags.

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic