[LTP] [PATCH v5] save_restore: Introduce new struct field for flags

[Martin Doucha]

On 17. 11. 22 4:59, Li Wang wrote:
> I didn't see any test using TST_SR_IGNORE_ERR flag in this patch,
> is this prepared for the coming patchset?

No, I've added TST_SR_IGNORE_ERR just in case we need to work around 
some sysfile kernel bugs in the future. I don't have any use for it so far.

>     +
>     +#define TST_SR_TCONF (TST_SR_TCONF_MISSING | TST_SR_TCONF_RO)
>     +#define TST_SR_TBROK (TST_SR_TBROK_MISSING | TST_SR_TBROK_RO)
>     +#define TST_SR_SKIP (TST_SR_SKIP_MISSING | TST_SR_SKIP_RO)
> 
> 
> I'd suggest using "_TSKIP" to replace "_SKIP' to be consistent.
> Then the whole format will look quite perfect and easy to memorize:).

I agree with Cyril, _SKIP does not refer to any result flag so it should 
not look like one.

Thanks for review.

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic