[LTP] [PATCH v5] save_restore: Introduce new struct field for flags

Jan Stancek jstancek@redhat.com
Tue Nov 22 09:02:02 CET 2022


On Fri, Nov 18, 2022 at 2:30 PM Cyril Hrubis <chrubis@suse.cz> wrote:
>
> Hi!
> > > +#define TST_SR_TCONF (TST_SR_TCONF_MISSING | TST_SR_TCONF_RO)
> > > +#define TST_SR_TBROK (TST_SR_TBROK_MISSING | TST_SR_TBROK_RO)
> > > +#define TST_SR_SKIP (TST_SR_SKIP_MISSING | TST_SR_SKIP_RO)
> > >
> >
> > I'd suggest using "_TSKIP" to replace "_SKIP' to be consistent.
> > Then the whole format will look quite perfect and easy to memorize:).
>
> I think that it makse sense to keep it as _SKIP because that is the
> option that does not map directly to the test result flags. If we named
> it TSKIP people will be confused that there is no TSKIP in the test
> result flags at all.

+1 for SKIP

Feel free to add my Acked-by back.



More information about the ltp mailing list